Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deps #226

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: deps #226

merged 1 commit into from
Dec 12, 2023

Conversation

Ademsk1
Copy link
Contributor

@Ademsk1 Ademsk1 commented Dec 12, 2023

Fixes mdx docs

@Ademsk1 Ademsk1 changed the title fix: babel fix: deps Dec 12, 2023
review-bot-for-github[bot]
review-bot-for-github bot reviewed Dec 12, 2023
View reviewed changes
Copy link

@review-bot-for-github review-bot-for-github bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments.

@github-actions GitHub Actions
Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

simoneb
simoneb reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where does this change come from? and how was it done in a way that only affects the lockfile?

@Ademsk1
Copy link
Contributor Author

Ademsk1 commented Dec 12, 2023

@simoneb Looks like some dependencies aren't updated when running npm ci. I deleted node_modules and package-lock.json, and then ran npm i. Running locally, the docs seem to be fixed. Some of the changes are babel related.

@simoneb
Copy link
Member

simoneb commented Dec 12, 2023

interesting. ok that's the right approach, just wanted to make sure the lockfile wasn't modified manually

@Ademsk1 Ademsk1 requested a review from swdilip December 12, 2023 16:01
swdilip
swdilip approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@swdilip swdilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this and the docs are back up and running! Nicely done 👍🏾

@Ademsk1 Ademsk1 merged commit 6f20e9b into main Dec 12, 2023
@Ademsk1 Ademsk1 deleted the fix/cant_find_content branch December 12, 2023 16:19
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
Closed
This was referenced Dec 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb left review comments

@review-bot-for-github review-bot-for-github[bot] review-bot-for-github[bot] left review comments

@swdilip swdilip swdilip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ademsk1 @simoneb @swdilip