Feat/36 pagination controls #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![review-bot-for-github[bot]](https://avatars.githubusercontent.com/u/1544687?s=60&v=4){kind=small}
|
Please link to an issue |
nherment
suggested changes
Dec 7, 2023
There was a problem hiding this comment.
Some comments on the design:
- The chevrons are not aligned with the numbers
- The chevron should be centered in their box. This is visible in the storybook on hover state with a dark background
- The background (hover state) should have rounded corners but it seems it doesn't for the chevrons?
Screen.Recording.2023-12-07.at.15.55.35.mov
nherment
approved these changes
Dec 14, 2023
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36