Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated bg values and added focus shadow #173

Merged
merged 2 commits into from
Nov 24, 2023
Merged

feat: updated bg values and added focus shadow #173

merged 2 commits into from
Nov 24, 2023

Conversation

swdilip
Copy link
Contributor

@swdilip swdilip commented Nov 23, 2023

closes #161

  • Updated values of background-color and added drop shadow on focus states

review-bot-for-github[bot]
review-bot-for-github bot reviewed Nov 23, 2023
View reviewed changes
Copy link

@review-bot-for-github review-bot-for-github bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments.

@swdilip swdilip requested a review from Ademsk1 November 23, 2023 16:28
Ademsk1
Ademsk1 suggested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Ademsk1 Ademsk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, minor things to change here. Be aware that the Button Group will need some fixing, but let's resolve that after this is in :D

Ademsk1
Ademsk1 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Ademsk1 Ademsk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swdilip swdilip merged commit 89bcd35 into main Nov 24, 2023
@swdilip swdilip deleted the feat/161_Button_styling_update branch November 24, 2023 17:05
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Closed
@optic-release-automation optic-release-automation bot mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@review-bot-for-github review-bot-for-github[bot] review-bot-for-github[bot] left review comments

@Ademsk1 Ademsk1 Ademsk1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update] - Button
2 participants
@swdilip @Ademsk1