Post SDK 52 migration | Step 3: app design rebrand #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
finnmerlett
commented
Feb 4, 2025
| > | ||
| <Text style={styles.seeTokensText}>SEE TOKENS</Text> | ||
| See tokens |
There was a problem hiding this comment.
Many snapshots and a few test files need updating to complete this PR
finnmerlett
commented
Feb 4, 2025
| @@ -166,29 +167,29 @@ export const NotificationCard: React.FC<NotificationCardProps> = ({ | |||
| </View> | |||
| <View style={{ ...styles.cardRow, flexDirection: 'row' }}> | |||
| {expired ? ( | |||
There was a problem hiding this comment.
This expired variable is (erroneously?) true if the notification.date is 0. This is happening at the moment, I think because of a bug in the date parsing and modification process when the notification arrives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update app theme to match new designs: https://www.figma.com/design/SZygq93AtTJQHx1ajTmdls/Optic-Expo---UI-Refresh?node-id=1-1615&p=f&t=EGPYWb36wZ727s02-0
Closes item 3 in the post-migration steps
Relates to #1388