fix: move skip check

nearform · Jan 7, 2025 · db10fdf · db10fdf
1 parent c76c315
commit db10fdf
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/graphql-hooks/src/useSubscription.ts b/packages/graphql-hooks/src/useSubscription.ts
@@ -22,17 +22,17 @@ function useSubscription<
   const contextClient = useContext(ClientContext)
   const client = options.client || contextClient
 
-  if (options.skip) {
-    return
-  }
-
   if (!client) {
     throw new Error(
       'useSubscription() requires a client to be passed in the options or as a context value'
     )
   }
 
   useDeepCompareEffect(() => {
+    if (options.skip) {
+      return
+    }
+
     const request = {
       query: options.query,
       variables: options.variables
@@ -55,7 +55,7 @@ function useSubscription<
     return () => {
       subscription.unsubscribe()
     }
-  }, [options.query, options.variables])
+  }, [options.query, options.variables, options.skip])
 }
 
 export default useSubscription