Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: use fetch #322

Merged
merged 2 commits into from
Nov 21, 2024
Merged

BREAKING CHANGE: use fetch #322

merged 2 commits into from
Nov 21, 2024

Conversation

ilteoood
Copy link
Contributor

This PR include a breaking change: node-fetch has been removed in favour of integrated node fetch.

Additionally, all the tests have been migrated to node test runner.

@simoneb I would like to wait before creating a new release for this, as I would like to upgrade also fastify to v5, on another PR.

Copy link

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@simoneb
Copy link
Member

simoneb commented Nov 21, 2024

can you please use the conventional commits specification in the PR title and commits? https://www.conventionalcommits.org/en/v1.0.0/#specification

@ilteoood ilteoood changed the title breaking: use fetch BREAKING CHANGE: use fetch Nov 21, 2024
@ilteoood
Copy link
Contributor Author

@simoneb done

@simoneb simoneb merged commit 59f8c1b into nearform:main Nov 21, 2024
5 of 6 checks passed
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants