Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add user defined domain validation #227

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

eugenio-oddone
Copy link
Contributor

Relates to #226

Adds support for an optional function to validate a token's domain when allowedDomains functionality does not suffice.

@eugenio-oddone eugenio-oddone added the enhancement New feature or request label Aug 8, 2023
@eugenio-oddone eugenio-oddone self-assigned this Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CyanoFresh can you check if this would solve your issue?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/get-jwks.js Show resolved Hide resolved
Co-authored-by: Simone Busoli <simone.busoli@gmail.com>
@CyanoFresh
Copy link

CyanoFresh commented Aug 8, 2023

@CyanoFresh can you check if this would solve your issue?

yes!
upd: but still strange for me that allowedDomains is not checking domains, but the whole issuer string. Maybe it is better to rename to something like issuersWhitelist in next major release

@simoneb
Copy link
Member

simoneb commented Aug 8, 2023

@CyanoFresh can you check if this would solve your issue?

yes! upd: but still strange for me that allowedDomains is not checking domains, but the whole issuer string. Maybe it is better to rename to something like issuersWhitelist in next major release

I agree, this is probably a leftover from the former implementation which was exclusively auth0.

@eugenio-oddone can you create an issue to track this request?

@eugenio-oddone
Copy link
Contributor Author

@CyanoFresh can you check if this would solve your issue?

yes! upd: but still strange for me that allowedDomains is not checking domains, but the whole issuer string. Maybe it is better to rename to something like issuersWhitelist in next major release

I agree, this is probably a leftover from the former implementation which was exclusively auth0.

@eugenio-oddone can you create an issue to track this request?

Yes will do 👍

@eugenio-oddone eugenio-oddone merged commit 056df88 into main Aug 8, 2023
@eugenio-oddone eugenio-oddone deleted the update-allowed-domains-verification branch August 8, 2023 19:43
@github-actions github-actions bot mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants