BREAKING CHANGE: fastify v5 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No linked issues found. Please add the corresponding issues in the pull request description. |
simoneb
previously approved these changes
Nov 21, 2024
|
@ilteoood CI is failing, can you take a look? |
Sure thing |
ilteoood
force-pushed
the
breakling/support-fastify-v5
branch
from
682bdc5 to
1526755
Compare
ilteoood
force-pushed
the
breakling/support-fastify-v5
branch
from
0f33c15 to
cbd25be
Compare
The PR is failing because it doesn't have access to the vars to be properly executed. Instead of a fork, it should be a normal PR from this repo in order to access them. I tried also running it locally, but the credentials on bitwarden seems to be expired. What if we merge it and see the outcome on the main branch? |
simoneb
reviewed
Nov 21, 2024
|
@ilteoood github seems to be having some issues with this repo, try maybe force pushing to trigger another sync |
ilteoood
force-pushed
the
breakling/support-fastify-v5
branch
from
1526755 to
3cda2a7
Compare
simoneb
approved these changes
Nov 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the structure of the tests I've not been able to run them locally
Note: this contains a breaking change