Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions #5

Closed
jsumners opened this issue Nov 20, 2019 · 1 comment
Closed

Some questions #5

jsumners opened this issue Nov 20, 2019 · 1 comment

Comments

@jsumners
Copy link

const fetch = require('node-fetch')

Does this library suffer from not handling timeouts like the web browser version (whatwg/fetch#20)? Might it be better to use a Node native module like got?

server.register(require('fastify-auth0-verify'), options)

This options is not defined in the example. Shouldn't the example be copy and paste-able as-is?

@ShogunPanda
Copy link
Contributor

ShogunPanda commented Nov 20, 2019

Good point on fetch. @mcollina Any preference on that?

Thanks for catching the options. Will remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants