Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration from jsonrpc-v2 to actix #344

Merged
merged 10 commits into from
Aug 22, 2024

Conversation

frolvanya
Copy link
Collaborator

@frolvanya frolvanya commented Aug 19, 2024

This migration would help us to:

  • Implement custom status codes (200, 400, 404, 408 and 500) like we do it in jsonrpc
  • Build a unified server configuration across jsonrpc and read-rpc
  • Implement a public jsonrpc trait to have same definition of rpc methods

@frolvanya frolvanya marked this pull request as ready for review August 21, 2024 04:24
rpc-server/src/main.rs Outdated Show resolved Hide resolved
@frolvanya
Copy link
Collaborator Author

@race-of-sloths

@race-of-sloths
Copy link

race-of-sloths commented Aug 21, 2024

@frolvanya Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Congratulatory messages are spent out! Your results have exceeded our imagination!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@khorolets 8

Your contribution is much appreciated with a final score of 8!
You have received 126 (80 base + 30 weekly bonus + 10 monthly bonus + 5% lifetime bonus) Sloth points for this contribution

Congratulations @frolvanya! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frolvanya frolvanya force-pushed the feat/migration-to-actix branch 4 times, most recently from f6ab873 to 4fd2e78 Compare August 22, 2024 03:15
Instead of hardcoding proper method names to RpcMethods hashmap, we can simply increase metrics only if the request succeeded. In this case we don't need to double check whether this method is correct or not, because we know it for sure
@khorolets
Copy link
Member

@race-of-sloths score 8

@frolvanya frolvanya merged commit 0b04372 into near:database-new Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants