Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split error metrics to disambiguate the reason #97

Closed
khorolets opened this issue Aug 3, 2023 · 1 comment · Fixed by #98
Closed

Split error metrics to disambiguate the reason #97

khorolets opened this issue Aug 3, 2023 · 1 comment · Fixed by #98

Comments

@khorolets
Copy link
Member

@kobayurii @telezhnaya
I've talked to @gmilescu, who suggested we split the errors in the counters. Something like:

  • block_error_proxies_counter_0 - RR success, AR success - data mismatch
  • block_error_proxies_counter_1 - RR success, AR error
  • block_error_proxies_counter_3 - RR error, AR success

This is similar to what @kobayurii did in #93 PR for separating logs. What do you think?

Originally posted by @khorolets in #93 (comment)
@telezhnaya
Copy link
Collaborator

I agree, but we should also add a fourth option
block_error_proxies_counter_4 - RR error, AR error, data mismatch

khorolets added a commit that referenced this issue Aug 9, 2023
@khorolets
refactor(rpc-server): Split error metrics to disambiguate the error r…
e0f82aa 
…easons #97
@khorolets khorolets mentioned this issue Aug 9, 2023
Merged
khorolets added a commit that referenced this issue Aug 10, 2023
@khorolets @telezhnaya
refactor(rpc-server): Split error metrics to disambiguate the error r…
d1707e6 
…easons (#98)

* refactor(rpc-server): Split error metrics to disambiguate the error reasons #97

* fix(rpc-server): README metric error codes fix grammar

* Update rpc-server/README.md

Co-authored-by: Olga Telezhnaya <olyatelezhnaya@gmail.com>

---------

Co-authored-by: Olga Telezhnaya <olyatelezhnaya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(rpc-server): Split error metrics to disambiguate the error reasons near/read-rpc
2 participants
@khorolets @telezhnaya