refactor: Move synchronisation logic to LifecycleManger
#1005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the synchronisation logic within
ExecutorsHandler
/BlockStreamsHandler
in toLifecycleManager
. The motive behind this is to provide greater awareness/control over the individual sync tasks (managing unhealthy, reconfiguring, etc.) toLifecycleManger
.I plan to build on top of this in my next PR, and have
LifecycleManager
count how many times an unhealthy stream/executor was restarted, and move the Indexer toSuspended
if it goes above a configured threshold. This refactor makes "counting" actually possible.Wanted to land the refactor PR first to make review easier.