Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hash of the node to the MissingTrieValue #9616

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Add hash of the node to the MissingTrieValue #9616

merged 3 commits into from
Oct 3, 2023

Conversation

staffik
Copy link
Contributor

@staffik staffik commented Sep 29, 2023 •
edited
Loading

Addressing

nearcore/core/primitives/src/errors.rs

Line 86 in 65af455

/// TODO (#8997): consider including hash of trie node.

@staffik staffik force-pushed the missing-trie-value-node-hash branch 2 times, most recently from 3c10e68 to ced00c2 Compare September 29, 2023 13:44
@staffik staffik changed the title [WIP] Add hash of the node to the MissingTrieValue Add hash of the node to the MissingTrieValue Sep 29, 2023
@staffik staffik marked this pull request as ready for review October 2, 2023 11:19
@staffik staffik requested a review from a team as a code owner October 2, 2023 11:19
@staffik staffik requested review from Longarithm and wacban October 2, 2023 11:19
wacban
wacban reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for looking into it!
The only real comment is to replace string with (context, hash), back to you for this final improvement, otherwise looks great.

core/primitives/src/errors.rs Outdated Show resolved Hide resolved
core/store/src/trie/iterator.rs Outdated Show resolved Hide resolved
core/store/src/trie/mod.rs Outdated Show resolved Hide resolved
core/store/src/trie/state_parts.rs Outdated Show resolved Hide resolved
@staffik staffik force-pushed the missing-trie-value-node-hash branch 5 times, most recently from 8d80b20 to b497893 Compare October 2, 2023 15:31
@wacban
Copy link
Contributor

wacban commented Oct 2, 2023

for sanity checks there is a script that you can use to run it locally:
./scripts/run_clippy.sh

@staffik staffik force-pushed the missing-trie-value-node-hash branch from b497893 to b9e5158 Compare October 3, 2023 07:14
@staffik staffik requested a review from wacban October 3, 2023 07:57
wacban
wacban approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Well done on your first PR in nearcore :)

core/primitives/src/errors.rs Outdated Show resolved Hide resolved
core/store/src/trie/iterator.rs Outdated Show resolved Hide resolved
@staffik staffik force-pushed the missing-trie-value-node-hash branch from b9e5158 to a46d222 Compare October 3, 2023 10:59
@staffik staffik added this pull request to the merge queue Oct 3, 2023
Merged via the queue into master with commit 74e9633 Oct 3, 2023
@staffik staffik deleted the missing-trie-value-node-hash branch October 3, 2023 14:33
nikurt pushed a commit that referenced this pull request Oct 11, 2023
@staffik @nikurt
Add hash of the node to the MissingTrieValue (#9616)
9192147 
Addressing

https://github.com/near/nearcore/blob/65af455f6f7f1bb8bc8cb399666468daebb28c66/core/primitives/src/errors.rs#L86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wacban wacban wacban approved these changes

@Longarithm Longarithm Awaiting requested review from Longarithm Longarithm is a code owner automatically assigned from near/nearcore-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staffik @wacban