[resharding] Use state sync snapshots to get flat storage iterator at a precise block #9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikurt
pushed a commit
that referenced
this pull request
Oct 3, 2023
… a precise block (#9598) With the current implementation for flat storage iterator, we have the issue that we can not control the block over which we create the iterator. A solution to that is to use the snapshot mechanism from state sync. We can assume that the snapshot would be created on all nodes as of the last block of an epoch. The way we get the correct state for resharding is that we take the snapshot as of the `prev_prev_hash` and append the delta from the `prev_hash` so that the state of the child tries/shards matches that of the last block of prev epoch.
wacban
reviewed
Oct 3, 2023
| })?; | ||
| let flat_storage_iter = | ||
| flat_storage_chunk_view.iter_flat_state_entries(None, None).map(|entry| { | ||
| let (key, value) = entry.unwrap(); |
There was a problem hiding this comment.
I missed it yesterday but we should properly propagate that error.
| let new_shards = next_epoch_shard_layout | ||
| .get_split_shard_uids(shard_id) | ||
| .ok_or(Error::InvalidShardId(shard_id))?; | ||
| let mut state_roots: HashMap<_, _> = | ||
| new_shards.iter().map(|shard_uid| (*shard_uid, Trie::EMPTY_ROOT)).collect(); | ||
|
|
||
| // Build the required iterator from flat storage and delta changes. Note that we are |
There was a problem hiding this comment.
nit: Can you refactor this to a separate method?
hehe gotcha ;)
nikurt
pushed a commit
that referenced
this pull request
Oct 11, 2023
… a precise block (#9598) With the current implementation for flat storage iterator, we have the issue that we can not control the block over which we create the iterator. A solution to that is to use the snapshot mechanism from state sync. We can assume that the snapshot would be created on all nodes as of the last block of an epoch. The way we get the correct state for resharding is that we take the snapshot as of the `prev_prev_hash` and append the delta from the `prev_hash` so that the state of the child tries/shards matches that of the last block of prev epoch.
nikurt
pushed a commit
that referenced
this pull request
Oct 11, 2023
… a precise block (#9598) With the current implementation for flat storage iterator, we have the issue that we can not control the block over which we create the iterator. A solution to that is to use the snapshot mechanism from state sync. We can assume that the snapshot would be created on all nodes as of the last block of an epoch. The way we get the correct state for resharding is that we take the snapshot as of the `prev_prev_hash` and append the delta from the `prev_hash` so that the state of the child tries/shards matches that of the last block of prev epoch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current implementation for flat storage iterator, we have the issue that we can not control the block over which we create the iterator. A solution to that is to use the snapshot mechanism from state sync.
We can assume that the snapshot would be created on all nodes as of the last block of an epoch.
The way we get the correct state for resharding is that we take the snapshot as of the
prev_prev_hashand append the delta from theprev_hashso that the state of the child tries/shards matches that of the last block of prev epoch.