Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoutingTableView: gracefully handle missing distance vectors #9394

Merged
merged 3 commits into from
Aug 8, 2023
Merged

RoutingTableView: gracefully handle missing distance vectors #9394

merged 3 commits into from
Aug 8, 2023

Conversation

saketh-are
Copy link
Collaborator

The RoutingTableView in the debug UI includes a table over the direct peers of the node:

image

Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer.

In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.

@saketh-are saketh-are requested review from wacban and a user August 7, 2023 13:50
@saketh-are saketh-are marked this pull request as ready for review August 7, 2023 13:50
@saketh-are saketh-are requested a review from a team as a code owner August 7, 2023 13:50
wacban
wacban approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll get an extra wac-point if you add an extra space in the empty space so that it's aligned ;)
Unless html and it would take a week and three frameworks to do this.

@saketh-are
Copy link
Collaborator Author

Added an _ to denote empty entries in the distance vector. Unfortunately I don't think the font is monospaced so the alignment is better but not perfect.

@near-bulldozer near-bulldozer bot merged commit e467916 into near:master Aug 8, 2023
nikurt pushed a commit that referenced this pull request Aug 8, 2023
@saketh-are @nikurt
RoutingTableView: gracefully handle missing distance vectors (#9394)
569e230 
The RoutingTableView in the debug UI includes a table over the direct peers of the node:

<img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c">

Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer.

In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.
near-bulldozer bot pushed a commit that referenced this pull request Aug 9, 2023
@nikurt @saketh-are
fix(state-sync): Enable State Sync from GCS by default (#9398)
63170aa 
* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* RoutingTableView: gracefully handle missing distance vectors (#9394)

The RoutingTableView in the debug UI includes a table over the direct peers of the node:

<img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c">

Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer.

In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

---------

Co-authored-by: Saketh Are <saketh.are@gmail.com>
ppca pushed a commit that referenced this pull request Aug 9, 2023
@nikurt @saketh-are @ppca
fix(state-sync): Enable State Sync from GCS by default (#9398)
047d72e 
* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* RoutingTableView: gracefully handle missing distance vectors (#9394)

The RoutingTableView in the debug UI includes a table over the direct peers of the node:

<img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c">

Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer.

In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

---------

Co-authored-by: Saketh Are <saketh.are@gmail.com>
nikurt pushed a commit that referenced this pull request Aug 24, 2023
@saketh-are @nikurt
RoutingTableView: gracefully handle missing distance vectors (#9394)
45dc42f 
The RoutingTableView in the debug UI includes a table over the direct peers of the node:

<img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c">

Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer.

In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.
nikurt added a commit that referenced this pull request Aug 24, 2023
@nikurt @saketh-are
fix(state-sync): Enable State Sync from GCS by default (#9398)
a8715eb 
* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* RoutingTableView: gracefully handle missing distance vectors (#9394)

The RoutingTableView in the debug UI includes a table over the direct peers of the node:

<img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c">

Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer.

In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

---------

Co-authored-by: Saketh Are <saketh.are@gmail.com>
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Aug 24, 2023
@saketh-are @nikurt
RoutingTableView: gracefully handle missing distance vectors (near#9394)
ccfc82a 
The RoutingTableView in the debug UI includes a table over the direct peers of the node:

<img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c">

Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer.

In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.
nikurt added a commit to nikurt/nearcore that referenced this pull request Aug 24, 2023
@nikurt @saketh-are
fix(state-sync): Enable State Sync from GCS by default (near#9398)
178fdec 
* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* RoutingTableView: gracefully handle missing distance vectors (near#9394)

The RoutingTableView in the debug UI includes a table over the direct peers of the node:

<img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c">

Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer.

In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

---------

Co-authored-by: Saketh Are <saketh.are@gmail.com>
nikurt added a commit that referenced this pull request Aug 28, 2023
@nikurt @saketh-are
fix(state-sync): Enable State Sync from GCS by default (#9398)
0084504 
* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* RoutingTableView: gracefully handle missing distance vectors (#9394)

The RoutingTableView in the debug UI includes a table over the direct peers of the node:

<img width="516" alt="image" src="https://github.com/near/nearcore/assets/3241341/c8c1f0b8-1e0a-458e-a2ad-f09f20fcb57c">

Each active connection of the node has one row in the table. The last column is populated using the most recent distance vector shared by the direct peer.

In some cases there may be a direct connection for which we have not received a distance vector yet. This PR allows the debug UI to gracefully handle such cases and display "null" instead of producing an error.

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

* fix(state-sync): Enable State Sync from GCS by default

---------

Co-authored-by: Saketh Are <saketh.are@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wacban wacban wacban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saketh-are @wacban