feat: split the simple resharding test to separately test the V1 and V2 reshardings #9373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| let shard_id = shard_id as ShardId; | ||
|
|
||
| for (i, me) in env.validators.iter().enumerate() { |
There was a problem hiding this comment.
This is a new addition, why are we adding this now in the test?
There was a problem hiding this comment.
I discovered that when starting with 4 shards from genesis the validators don't track all shards. I tried to adjust the test to handle that correctly. Eventually I had to give up when I hit the issue with state sync. I'm not going to be fixing that now but we do have it planned for this month. Anyway this code is correct and will make the transition to not all validators tracking all shards easier in the future.
shreyan-gupta
approved these changes
Aug 1, 2023
nikurt
pushed a commit
that referenced
this pull request
Aug 24, 2023
…V2 reshardings (#9373) * feat: splitting the simple resharding test to separately test V1 and V2 reshardings * devlog * debugging * should be fine * revert debug logging * rust features are hard
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Aug 24, 2023
…V2 reshardings (near#9373) * feat: splitting the simple resharding test to separately test V1 and V2 reshardings * devlog * debugging * should be fine * revert debug logging * rust features are hard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the simple resharding test performs two reshardings in a row: V0->V1 and V1->V2. This approach is generally fine but it won't work with the flat storage approach to trie splitting until we also support resharding flat storage. In order to decouple the workstreams and divide them to smaller milestones I'm refactoring the tests so that we can just execute a single resharding and not verify flat storage for the time being.
In this PR I divided the simple test into two smaller test. Each test performs only one resharding.