feature: Stabilize Compute Costs #8892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborg-dev
force-pushed
the
compute_costs_stabilization
branch
from
eb03ed5 to
d4cb8dc
Compare
aborg-dev
added
the
A-contract-runtime
jakmeier
requested changes
Apr 6, 2023
Comment on lines
+2561
to
+2572
| let sha256_cost = ParameterCost { | ||
| gas: Gas::from(1_000_000u64), | ||
| compute: if checked_feature!( | ||
| "stable", | ||
| ComputeCosts, | ||
| apply_state.current_protocol_version | ||
| ) { | ||
| Compute::from(10_000_000_000_000u64) | ||
| } else { | ||
| Compute::from(1_000_000u64) | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Unless you want to add a test that checks a version before the feature was added, I don't think you need this checked_feature!, right? (Assuming we bump the protocol version first)
There was a problem hiding this comment.
I've addressed this in #8915
| @@ -238,6 +242,7 @@ impl ProtocolFeature { | |||
| ProtocolFeature::Ed25519Verify | |||
| | ProtocolFeature::ZeroBalanceAccount | |||
| | ProtocolFeature::DelegateAction => 59, | |||
| ProtocolFeature::ComputeCosts => 61, | |||
There was a problem hiding this comment.
When (or before) we can put stable protocol features to version 61, we have to bump STABLE_PROTOCOL_VERSION to 61. We usually do it in the same PR as the feature stabilization, so you can do it directly in this PR. That should also make stable tests easier.
There was a problem hiding this comment.
I've addressed this in #8915
|
I've replaced this PR with #8915 |
near-bulldozer bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
This PR re-introduces changes from #8805 together with #8892 after fixing #8908: The PR addresses #8265 by introducing aggregation of compute usage across all operations performed during chunk application and limiting this compute usage to 1s. This should not change the behavior of nodes in the short run because compute costs match gas costs which is validated by the assert, so any discrepancy should be caught on canary nodes.
nikurt
pushed a commit
that referenced
this pull request
Apr 18, 2023
This PR re-introduces changes from #8805 together with #8892 after fixing #8908: The PR addresses #8265 by introducing aggregation of compute usage across all operations performed during chunk application and limiting this compute usage to 1s. This should not change the behavior of nodes in the short run because compute costs match gas costs which is validated by the assert, so any discrepancy should be caught on canary nodes.
nikurt
pushed a commit
that referenced
this pull request
Apr 18, 2023
This PR re-introduces changes from #8805 together with #8892 after fixing #8908: The PR addresses #8265 by introducing aggregation of compute usage across all operations performed during chunk application and limiting this compute usage to 1s. This should not change the behavior of nodes in the short run because compute costs match gas costs which is validated by the assert, so any discrepancy should be caught on canary nodes.
nikurt
pushed a commit
that referenced
this pull request
Apr 25, 2023
This PR re-introduces changes from #8805 together with #8892 after fixing #8908: The PR addresses #8265 by introducing aggregation of compute usage across all operations performed during chunk application and limiting this compute usage to 1s. This should not change the behavior of nodes in the short run because compute costs match gas costs which is validated by the assert, so any discrepancy should be caught on canary nodes.
nikurt
pushed a commit
that referenced
this pull request
Apr 25, 2023
This PR re-introduces changes from #8805 together with #8892 after fixing #8908: The PR addresses #8265 by introducing aggregation of compute usage across all operations performed during chunk application and limiting this compute usage to 1s. This should not change the behavior of nodes in the short run because compute costs match gas costs which is validated by the assert, so any discrepancy should be caught on canary nodes.
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
This PR re-introduces changes from #8805 together with #8892 after fixing #8908: The PR addresses #8265 by introducing aggregation of compute usage across all operations performed during chunk application and limiting this compute usage to 1s. This should not change the behavior of nodes in the short run because compute costs match gas costs which is validated by the assert, so any discrepancy should be caught on canary nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the compile time feature "protocol_feature_compute_costs" and replace all checks in the code to look at the current protocol version instead.