Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create NodeStorage from checkpoint #8876

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

posvyatokum
Copy link
Member

This should be safe to use with already open db.
Not sure about easy, though. home_dir, config, and archive flag are not available everywhere right now without any hustle.

@posvyatokum posvyatokum requested a review from nikurt April 3, 2023 21:00
@posvyatokum posvyatokum requested a review from a team as a code owner April 3, 2023 21:00
Copy link
Contributor

@nikurt nikurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Would look even better if it had a unit test.

core/store/src/opener.rs Outdated Show resolved Hide resolved
core/store/src/opener.rs Outdated Show resolved Hide resolved
@near-bulldozer near-bulldozer bot merged commit 5e174de into master Apr 4, 2023
@near-bulldozer near-bulldozer bot deleted the database-checkpoint branch April 4, 2023 10:10
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Apr 5, 2023
This should be safe to use with already open db.
Not sure about easy, though. home_dir, config, and archive flag are not available everywhere right now without any hustle.
nikurt pushed a commit that referenced this pull request Apr 28, 2023
This should be safe to use with already open db.
Not sure about easy, though. home_dir, config, and archive flag are not available everywhere right now without any hustle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants