-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: rosetta zero balance accounts tests #8833
Merged
near-bulldozer
merged 6 commits into
master
from
fix/rosetta-zero-balance-accounts-tests
Apr 4, 2023
Merged
Fix: rosetta zero balance accounts tests #8833
near-bulldozer
merged 6 commits into
master
from
fix/rosetta-zero-balance-accounts-tests
Apr 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakmeier
reviewed
Mar 29, 2023
jakmeier
approved these changes
Mar 30, 2023
firatNEAR
approved these changes
Apr 3, 2023
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Apr 5, 2023
(My bad, didn't realize that the `S-automerge` tag would merge both directions, so this is a separate PR.) Also a bit of clean-up w.r.t. magic numbers. Implicit account test no longer has to worry about the `LIQUID_BALANCE_FOR_STORAGE` subaccount.
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
(My bad, didn't realize that the `S-automerge` tag would merge both directions, so this is a separate PR.) Also a bit of clean-up w.r.t. magic numbers. Implicit account test no longer has to worry about the `LIQUID_BALANCE_FOR_STORAGE` subaccount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(My bad, didn't realize that the
S-automerge
tag would merge both directions, so this is a separate PR.)Also a bit of clean-up w.r.t. magic numbers.
Implicit account test no longer has to worry about the
LIQUID_BALANCE_FOR_STORAGE
subaccount.