test: access keys scenarios in meta transactions #8570
Conversation
Final set of tests to complement the integration tests listed in near#8467.
| assert_eq!( | ||
| allowance.unwrap(), | ||
| initial_allowance, | ||
| "allowance should not change, we used the relayer's fund not the sender's" |
There was a problem hiding this comment.
Should this also check relayer’s and sender’s balance to validate that relayer’s funds been used and that sender’s overall balance was also left untouched (regardless of what the kay’s allowance says?)
There was a problem hiding this comment.
check_meta_tx_fn_call does all these checks already, including complicated balance calculations for the 30% contract rewards and all that jazz
| deposit: 0, | ||
| })]; | ||
|
|
||
| let tx_result = node.user().meta_tx(sender, receiver, relayer, actions).unwrap(); |
There was a problem hiding this comment.
There's an unfortunate amount of duplication between the three tests added here? Would it be possible to consolidate them somehow?
There was a problem hiding this comment.
I tried my best to reduce duplication, but the consolidated function need an awful lot of parameters. See my latest commit.
In terms of LOC, I ended up with more code than before. But I think it's still an improvement, as the logical duplication is reduced. Not sure if the code is cleaner to read though.
jakmeier
force-pushed
the
meta-tx-integrations-tests-5
branch
from
7d59df9
to
63d6927
Compare
Final set of tests to complement the integration tests listed in #8467.