test: meta transaction FT transfer #8564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the example used for NEP-366, an FT transfer paid by the relayer but the relayer gets a reward. Adds `fungible_token.wasm` as a test contract, which is the example implementation of NEP-141 in the near-sdk-rs repository.
|
This was a bit trickier than I thought, but I think it's worth adding this scenario to our test suite. On a side note, I keep sending these tests in batches, because I personally prefer reviewing several small PRs than one huge PR. But I can also group the remaining tests together in this PR if you don't want to be spammed by review requests, just let me know. |
13 tasks
mm-near
approved these changes
Feb 14, 2023
|
|
||
| // let transfer_event: serde_json::Value = | ||
| // serde_json::from_str(&fn_call_logs[1]).expect("log events should be JSON"); | ||
| // assert_eq!(transfer_event, ft_transfer_event(&sender, &receiver, 1000)); |
There was a problem hiding this comment.
can you also check that david got the tokens ? (and that the token balance of alice & bob are correct)
There was a problem hiding this comment.
yes, I added a small helper assert_ft_balance and then
assert_ft_balance(&node, &ft_contract, &receiver, 1000);
assert_ft_balance(&node, &ft_contract, &sender, 10_000 - 1000 - 10);
assert_ft_balance(&node, &ft_contract, &relayer, 1_000_000 - 10_000 + 10);
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Feb 15, 2023
This is the example used for NEP-366, an FT transfer paid by the relayer but the relayer gets a reward in FT. Adds `fungible_token.wasm` as a test contract, which is the example implementation of NEP-141 in the near-sdk-rs repository. We deploy this WASM, initialize the state to make an FT transfer possible and then execute a meta transaction as intended. This makes gas checks in meta transaction tests even more annoying but otherwise the existing test framework mostly just worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the example used for NEP-366, an FT transfer paid by the
relayer but the relayer gets a reward in FT.
Adds
fungible_token.wasmas a test contract, which is theexample implementation of NEP-141 in the near-sdk-rs repository.
We deploy this WASM, initialize the state to make an FT transfer
possible and then execute a meta transaction as intended.
This makes gas checks in meta transaction tests even more annoying
but otherwise the existing test framework mostly just worked.