fix: disable integration tests that are broken on mac #8412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wacban
force-pushed
the
waclaw-disable-broken-on-mac
branch
2 times, most recently
from
357e372 to
4366941
Compare
wacban
commented
Jan 20, 2023
| use nearcore::config::GenesisExt; | ||
| #[cfg(all(feature = "wasmer0_vm", feature = "wasmer2_vm"))] | ||
| mod test_wasmer2_upgrade { | ||
| use crate::tests::client::process_blocks::{create_nightshade_runtimes, deploy_test_contract}; |
There was a problem hiding this comment.
best to review this with "hide whitespace" enabled...
|
TODO: after buildkite is done check logs and make sure that the tests were ran there |
Done, buildkite picked up all tests. |
nagisa
reviewed
Jan 20, 2023
| @@ -3473,6 +3473,8 @@ fn test_catchup_no_sharding_change() { | |||
| } | |||
| } | |||
|
|
|||
| /// These tests fail on aarch because the WasmtimeVM::precompile method doesn't populate the cache. | |||
| #[cfg(not(all(target_arch = "aarch64", target_vendor = "apple")))] | |||
There was a problem hiding this comment.
Thinking on this further, this is probably be better off as
#[cfg_attr(not(all(...)), ignore)]
on top of each failing test. A regular cfg as used here (admittedly suggested by myself at first) has a major downside – the code inside is not compiled. So if anybody on a Mac were to go on and change API of something that these tests touch, they would only learn of the fact that these tests do not compile at the CI. That's a pretty poor experience. A conditional #[ignore] helps with that issue a lot.
wacban
force-pushed
the
waclaw-disable-broken-on-mac
branch
from
b059135 to
44741f3
Compare
nagisa
approved these changes
Jan 22, 2023
near-bulldozer bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
As it fails with: ``` thread 'tests::test_contract_precompilation' panicked at 'Compilation result should be non-empty', runtime/runtime/src/lib.rs:2550:14 ``` presumably, because the compilation cache is not populated on aarch64-apple. A prior art: #8412
nikurt
pushed a commit
that referenced
this pull request
Apr 18, 2023
As it fails with: ``` thread 'tests::test_contract_precompilation' panicked at 'Compilation result should be non-empty', runtime/runtime/src/lib.rs:2550:14 ``` presumably, because the compilation cache is not populated on aarch64-apple. A prior art: #8412
nikurt
pushed a commit
that referenced
this pull request
Apr 25, 2023
As it fails with: ``` thread 'tests::test_contract_precompilation' panicked at 'Compilation result should be non-empty', runtime/runtime/src/lib.rs:2550:14 ``` presumably, because the compilation cache is not populated on aarch64-apple. A prior art: #8412
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
As it fails with: ``` thread 'tests::test_contract_precompilation' panicked at 'Compilation result should be non-empty', runtime/runtime/src/lib.rs:2550:14 ``` presumably, because the compilation cache is not populated on aarch64-apple. A prior art: #8412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made two types of tests conditionally compiled to exclude them from running on macbooks - because they don't work on macs anyway.
The test relies on the contract cache to be populated but the precompile method of the wasmtime runner doesn’t populate the cache
The test checks transition from wasmer0 to wasmer2 but wasmer0 and wasmer2 are not available on macs