feat: draft implementation of NEP-366 (fork) #8385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 30, 2022 00:02
This is a draft implementation of NEP-366 (near/NEPs#366) Not done yet: * Need to implement DelegateAction for implicit accounts (nonce problem) * Need new error codes for DelegateAction * Implement Fees for DelegateAction * Add tests
* Removed published_id * Added sender_id to DelegateAction * All things are verified when action is processing except verification of DelegateAction count in the transaction and verification wheher DelegateAction contains the nested ones * Added block_hash, nonce, public_key fields to DelegateAction * Gas is refunded to Transaction signer, deposit is refund to Receipt predecessor (because publisher_id has been removed) Need to be done: 1. `block_hash` isn't verified because there is not access to Store from `runtime' 2. Need to apply recommendation to `action_array_serde`: https://near.zulipchat.com/#narrow/stream/295302-general/topic/recursive.20types.20in.20borsh-rs/near/305181116 3. Need to add unit tests
* Handle a nested DelegateAction while the parent one is deserialized
1. Charge the inner actions' `send_fee` on Relayer shard and prepaid the `send_fee` for Sender shard 2. Burn the inner actions' `send_fee` on Sender shard (when DelegateAction is processed)
The feature flag enables DelegateAction support
This test fails if "protocol_feature_delegate_action" is disabled. Therefore another version of this test has been added which works on stable build.
Cause: runtime::config_store::tests::test_json_unchanged fails The following command created the snapshots: `cargo insta test --accept -p near-primitives -- test_json_unchanged`
- Update PROTOCOL_VERSION - Update ProtocolFeature::DelegateAction version number
jakmeier
requested review from
mzhangmzz and
mm-near
and removed request for
mzhangmzz
This was referenced Jan 18, 2023
Instead of relying on deserialization failing, remove the new action completely from non-nightly code. This should give us more confidence to merge this PR into nearcore.
|
@mm-near I have added a ton of While this can look a bit messy, I think it simplifies the PR a lot in terms of risks. Most code is now trivially ok to merge because it is only active in nightly. Ssuch as the PTAL if there is anything left you want resolved before we merge this. |
mm-near
approved these changes
Jan 19, 2023
Fixed, thanks! |
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Jan 30, 2023
A fork of near#7497 Nearcore code owners currently don't have permissions to change the original PR, so we will add the necessary changes here before merging. This is also merged with the current master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fork of #7497
Nearcore code owners currently don't have permissions to change the
original PR, so we will add the necessary changes here before merging.
This is also merged with the current master.
Original authors that came up with the implementation and design:
@e-uleyskiy
@fadeevab
See also NEP-366