Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't ban peers if the block timestamp is in the future #8327

Merged
merged 3 commits into from
Jan 17, 2023
Merged

don't ban peers if the block timestamp is in the future #8327

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f88dabc
don't ban peers if the block timestamp is in the future
Jan 6, 2023
d998747
Merge branch 'master' into timestamp
mzhangmzz Jan 10, 2023
b66b073
Merge branch 'master' into timestamp
mzhangmzz Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion chain/client/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,12 @@ impl Client {
Ok(())
}
Err(e) if e.is_bad_data() => {
self.ban_peer(peer_id.clone(), ReasonForBan::BadBlockHeader);
// We don't ban a peer if the block timestamp is too much in the future since it's possible
// that a block is considered valid in one machine and invalid in another machine when their
// clocks are not synced.
if !matches!(e, near_chain::Error::InvalidBlockFutureTime(_)) {
self.ban_peer(peer_id.clone(), ReasonForBan::BadBlockHeader);
}
Err(e)
}
Err(_) => {
Expand Down