deprecating AnnounceAccount #8182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
requested review from
akhi3030 and
mm-near
and removed request for
akhi3030
mm-near
approved these changes
Dec 9, 2022
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Dec 14, 2022
Deprecating AnnounceAccount in favor of AccountData, when finding routing target. AnnounceAccount will be still used as a fallback. In the next release, once we confirm that AnnounceAccount is not used any more, we will remove the fallback. We will stop broadcasting AnnounceAccount only once MIN_SUPPORTED_VERSION > 57.
nikurt
added a commit
to nikurt/nearcore
that referenced
this pull request
Jan 9, 2023
This reverts commit 1f0c57e.
near-bulldozer bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
This reverts commit 1f0c57e. This commit broke `tests/sanity/switch_node_key.py`. Reverting fixes the test. Context: https://near.zulipchat.com/#narrow/stream/295558-pagoda.2Fcore/topic/When.20can.201.2E31.20be.20cut/near/319867216
pompon0
added a commit
that referenced
this pull request
Jan 25, 2023
near-bulldozer bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
This is a roll forward of #8182 , which was reverted by #8314 . The issue that #8182 caused has been fixed in #8407 . nayduck run: https://nayduck.near.org/#/run/2834 before the fix tests/sanity/switch_node_key.py was failing, now it succeeds. No nayduck tests are newly failing with this PR, compared to master.
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Jan 26, 2023
This is a roll forward of near#8182 , which was reverted by near#8314 . The issue that near#8182 caused has been fixed in near#8407 . nayduck run: https://nayduck.near.org/#/run/2834 before the fix tests/sanity/switch_node_key.py was failing, now it succeeds. No nayduck tests are newly failing with this PR, compared to master.
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Jan 26, 2023
This is a roll forward of near#8182 , which was reverted by near#8314 . The issue that near#8182 caused has been fixed in near#8407 . nayduck run: https://nayduck.near.org/#/run/2834 before the fix tests/sanity/switch_node_key.py was failing, now it succeeds. No nayduck tests are newly failing with this PR, compared to master.
nikurt
added a commit
to nikurt/nearcore
that referenced
this pull request
Jan 30, 2023
This reverts commit 1f0c57e. This commit broke `tests/sanity/switch_node_key.py`. Reverting fixes the test. Context: https://near.zulipchat.com/#narrow/stream/295558-pagoda.2Fcore/topic/When.20can.201.2E31.20be.20cut/near/319867216
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Jan 30, 2023
This is a roll forward of near#8182 , which was reverted by near#8314 . The issue that near#8182 caused has been fixed in near#8407 . nayduck run: https://nayduck.near.org/#/run/2834 before the fix tests/sanity/switch_node_key.py was failing, now it succeeds. No nayduck tests are newly failing with this PR, compared to master.
ppca
pushed a commit
to ppca/nearcore
that referenced
this pull request
Jan 30, 2023
This is a roll forward of near#8182 , which was reverted by near#8314 . The issue that near#8182 caused has been fixed in near#8407 . nayduck run: https://nayduck.near.org/#/run/2834 before the fix tests/sanity/switch_node_key.py was failing, now it succeeds. No nayduck tests are newly failing with this PR, compared to master.
nikurt
added a commit
that referenced
this pull request
Feb 1, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
AnnounceAccounts is a legacy mechanism supporting Validator AccountId -> PeerId lookups. It was superseded by AccountsData about a year ago and has been awaiting deprecation: https://github.com/near/nearcore/blob/7c0b58fd02a7ecc401736628cc977f6c8cff5fbf/chain/network/src/peer_manager/network_state/mod.rs#L596-L606 By inspecting the `ACCOUNT_TO_PEER_LOOKUPS` metric for several mainnet validators, I've confirmed that AnnounceAccounts is no longer of use. Additionally, enough release versions have passed since the introduction of AccountsData that we can get rid of AnnounceAccounts entirely at this point (see #8182). This PR removes all of the client code which has to do with creation and usage of AnnounceAccounts. I plan to send separate PRs removing related fields/types from the network message protocol and deprecating `DBCol::AccountAnnouncements` (as this PR is large enough already).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecating AnnounceAccount in favor of AccountData, when finding routing target. AnnounceAccount will be still used as a fallback. In the next release, once we confirm that AnnounceAccount is not used any more, we will remove the fallback. We will stop broadcasting AnnounceAccount only once MIN_SUPPORTED_VERSION > 57.