runtime: don’t unnecessarily copy promise indices #8175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The promise_and method processes one promise index at a time. There’s no benefit in having all them in memory. Rather than copying the indices from Vec<u8> into a new Vec<u64> simply do the little endian conversion while going through the former vector. This saves an allocation.
|
@Ekleog-NEAR : can you review this PR please? |
nagisa
reviewed
Dec 7, 2022
nagisa
approved these changes
Dec 7, 2022
Ekleog-NEAR
approved these changes
Dec 8, 2022
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Dec 14, 2022
The promise_and method processes one promise index at a time. There’s no benefit in having all them in memory. Rather than copying the indices from Vec<u8> into a new Vec<u64> simply do the little endian conversion while going through the former vector. This saves an allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promise_and method processes one promise index at a time. There’s
no benefit in having all them in memory. Rather than copying the
indices from Vec into a new Vec simply do the little endian
conversion while going through the former vector. This saves an
allocation.