Migrate ping and ttl tests to network crate #8110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 23, 2022 19:27
saketh-are
force-pushed
the
migrate-ping-tests
branch
from
3e15c89
to
d83b1d7
Compare
saketh-are
force-pushed
the
migrate-ping-tests
branch
from
61c73d4
to
ad373ee
Compare
pompon0
reviewed
Nov 24, 2022
pompon0
reviewed
Nov 24, 2022
pompon0
approved these changes
Nov 25, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 26, 2022
These tests verify the behavior for basic pings, including interactions with TTL. This PR migrates them from integration-tests into the chain/network crate. The goals for this migration are to: -utilize the internal APIs of the near-network crate -make the tests await the changes rather than poll -to decrease the public API surface of the near-network crate
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests verify the behavior for basic pings, including interactions with TTL.
This PR migrates them from integration-tests into the chain/network crate. The goals for this migration are to:
-utilize the internal APIs of the near-network crate
-make the tests await the changes rather than poll
-to decrease the public API surface of the near-network crate