Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test checking if some of the crates compile to wasm32 [WIP] #4396

Closed
wants to merge 1 commit into from

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Jun 22, 2021

Still work in progress. Needs to settle on the list of packages to include in the test.

Issue: #4379

Comment on lines +154 to +155
tools/rpctypegen/macro \
tools/rpctypegen/core \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need these. They will be deprecated

test-utils/logger \
integration-tests \
pytest/empty-contract-rs \
core/metrics \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need this

core/primitives-core \
tools/rpctypegen/macro \
tools/rpctypegen/core \
create-near-app/common/contracts/rust \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this is part of nearcore?

@stale
Copy link

stale bot commented Jul 6, 2021

This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks.
It will be closed in 3 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jul 6, 2021
@bowenwang1996
Copy link
Collaborator

@mina86 do we still need this PR?

@stale stale bot removed the S-stale label Jul 6, 2021
@mina86 mina86 closed this Jul 6, 2021
@mina86 mina86 deleted the wasm branch July 9, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants