Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update gas price #3028

Merged
merged 6 commits into from
Jul 25, 2020
Merged

feat: update gas price #3028

merged 6 commits into from
Jul 25, 2020

Conversation

bowenwang1996
Copy link
Collaborator

Update gas price to 1_000_000_000 according to near/NEPs#92.

Test plan

  • upgradable.py with transactions.
  • spin up a node with this change and verify that it can sync to testnet and process blocks without any issue.

@bowenwang1996
Copy link
Collaborator Author

@vgrichina @kcole16 applayer needs to change access key allowance to 2 NEAR with this change.

evgenykuzyakov
evgenykuzyakov requested changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@evgenykuzyakov evgenykuzyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use constants differently. Instead of saying:

  • MIN_GAS_PRICE_V31 -> say NEP_92_MIN_GAS_PRICE
  • 31 -> say NEP_92_MIN_PROTOCOL_VERSION

This way we don't imply the gas price should go on version 31. In the future we should be able to batch multiple NEP changes into one protocol version.

@gitpod-io
Copy link

gitpod-io bot commented Jul 23, 2020 •
edited
Loading

@bowenwang1996 bowenwang1996 mentioned this pull request Jul 23, 2020
Merged
@weekly-digest weekly-digest bot mentioned this pull request Jul 24, 2020
Closed
frol
frol reviewed Jul 24, 2020
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough context to review the implications of this change, so I only glanced the code over.

chain/client/tests/challenges.rs Outdated Show resolved Hide resolved
chain/chain/src/types.rs Outdated Show resolved Hide resolved
SkidanovAlex
SkidanovAlex reviewed Jul 24, 2020
View reviewed changes
chain/chain/src/types.rs Outdated Show resolved Hide resolved
chain/chain/src/chain.rs Outdated Show resolved Hide resolved
@bowenwang1996 bowenwang1996 merged commit 9d7aaf5 into master Jul 25, 2020
@bowenwang1996 bowenwang1996 deleted the update-gas-price branch July 25, 2020 00:03
@weekly-digest weekly-digest bot mentioned this pull request Jul 31, 2020
Closed
@bowenwang1996 bowenwang1996 mentioned this pull request Jul 31, 2020
Merged
mhalambek added a commit that referenced this pull request Aug 3, 2020
@mhalambek
Revert "feat: update gas price (#3028)"
12cbe13 
This reverts commit 9d7aaf5.
bowenwang1996 added a commit that referenced this pull request Aug 6, 2020
@bowenwang1996
fix: gas price (#3067)
040cb15 
I made a typo in #3028 and updated gas price to 1B yotcoNEAR instead of 100M yotcoNEAR.

Test plan
---------
`upgradable.py`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol left review comments

@SkidanovAlex SkidanovAlex SkidanovAlex approved these changes

@evgenykuzyakov evgenykuzyakov evgenykuzyakov approved these changes

@MaksymZavershynskyi MaksymZavershynskyi Awaiting requested review from MaksymZavershynskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bowenwang1996 @frol @SkidanovAlex @evgenykuzyakov