Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resharding) - Make shard ids non-contiguous - part 2 #12209

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Oct 11, 2024

More of the same. I added a rust feature to quickly switch between the old and new shard ids to speed up work.

No interesting changes here, just syntax everywhere. I hope.

@wacban wacban requested a review from a team as a code owner October 11, 2024 15:18
@wacban wacban requested review from akhi3030 and Longarithm and removed request for akhi3030 October 11, 2024 15:18
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (2b022a6) to head (450ac7b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
core/primitives/src/shard_layout.rs 98.00% 0 Missing and 1 partial ⚠️
core/primitives/src/trie_key.rs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12209   +/-   ##
=======================================
  Coverage   71.74%   71.75%           
=======================================
  Files         825      825           
  Lines      165819   165865   +46     
  Branches   165819   165865   +46     
=======================================
+ Hits       118973   119018   +45     
  Misses      41650    41650           
- Partials     5196     5197    +1     
Flag Coverage Δ
backward-compatibility 0.17% <0.00%> (-0.01%) ⬇️
db-migration 0.17% <0.00%> (-0.01%) ⬇️
genesis-check 1.26% <8.19%> (+<0.01%) ⬆️
integration-tests 38.93% <55.76%> (+0.02%) ⬆️
linux 71.45% <98.07%> (+0.01%) ⬆️
linux-nightly 71.32% <98.07%> (-0.01%) ⬇️
macos 54.34% <96.15%> (+0.07%) ⬆️
pytests 1.58% <8.19%> (+<0.01%) ⬆️
sanity-checks 1.38% <0.00%> (-0.01%) ⬇️
unittests 65.52% <97.11%> (+<0.01%) ⬆️
upgradability 0.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wacban wacban enabled auto-merge October 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants