Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gc) - fix the chunk_tail <= tail invariant #12207

Merged
merged 2 commits into from
Oct 11, 2024
+7 −1
Merged

fix(gc) - fix the chunk_tail <= tail invariant #12207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0b2000
fix(gc) - fix the chunk_tail <= tail invariant
wacban Oct 11, 2024
5690fdf
per comment -> derive chunk tail from the tail block
wacban Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion chain/chain/src/chain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1679,7 +1679,13 @@ impl Chain {

tracing::debug!(target: "sync", ?min_height_included, ?new_tail, "adjusting tail for missing chunks");
new_tail = std::cmp::min(new_tail, min_height_included.saturating_sub(1));
let new_chunk_tail = prev_block.chunks().iter().map(|x| x.height_created()).min().unwrap();

// In order to find the right new_chunk_tail we need to find the minimum
// of chunk height_created for chunks in the new tail block.
let new_tail_block = self.get_block_by_height(new_tail)?;
let new_chunk_tail =
new_tail_block.chunks().iter().map(|chunk| chunk.height_created()).min().unwrap();

let tip = Tip::from_header(prev_block.header());
let final_head = Tip::from_header(self.genesis.header());
// Update related heads now.
Expand Down
Loading