fix(state sync): delete get_cached_state_parts #12197
Merged
+11
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12197 +/- ##
==========================================
- Coverage 71.69% 71.67% -0.02%
==========================================
Files 824 824
Lines 165526 165484 -42
Branches 165526 165484 -42
==========================================
- Hits 118670 118616 -54
- Misses 41709 41734 +25
+ Partials 5147 5134 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marcelo-gonzalez
approved these changes
Oct 9, 2024
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Oct 10, 2024
In testnet we observed `get_cached_state_parts` consistently taking ~58 seconds to run. Returning the list of cached state parts is a relic of the old decentralized state sync design. We no longer need this at all.
Merged
marcelo-gonzalez
added a commit
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testnet we observed
get_cached_state_partsconsistently taking ~58 seconds to run.Returning the list of cached state parts is a relic of the old decentralized state sync design. We no longer need this at all.