Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lifetimes in ProtocolSchema types #12120

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

Longarithm
Copy link
Member

Remove lifetimes from types generated by ProtocolSchema tooling.

Needed for #12031.

@Longarithm Longarithm requested a review from a team as a code owner September 20, 2024 13:21
Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@Longarithm Longarithm added this pull request to the merge queue Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.53%. Comparing base (4fe8380) to head (035e458).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12120      +/-   ##
==========================================
+ Coverage   71.52%   71.53%   +0.01%     
==========================================
  Files         819      819              
  Lines      164694   164694              
  Branches   164694   164694              
==========================================
+ Hits       117793   117812      +19     
+ Misses      41762    41741      -21     
- Partials     5139     5141       +2     
Flag Coverage Δ
backward-compatibility 0.17% <0.00%> (ø)
db-migration 0.17% <0.00%> (ø)
genesis-check 1.26% <0.00%> (ø)
integration-tests 38.65% <100.00%> (+0.01%) ⬆️
linux 71.31% <100.00%> (+<0.01%) ⬆️
linux-nightly 71.10% <100.00%> (-0.01%) ⬇️
macos 54.16% <100.00%> (+1.20%) ⬆️
pytests 1.52% <0.00%> (ø)
sanity-checks 1.33% <0.00%> (ø)
unittests 65.27% <100.00%> (+0.01%) ⬆️
upgradability 0.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit 08065ff Sep 20, 2024
27 of 29 checks passed
@Longarithm Longarithm deleted the ps-lifetimes branch September 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants