feat: Update neard init to specify config file type to download #12072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayfunelmas
changed the title
tayfunelmas
requested review from
akhi3030,
VanBarbascu,
marcelo-gonzalez and
khorolets
|
Adding @khorolets as reviewer due to the flag change for Indexers. |
tayfunelmas
commented
Sep 10, 2024
tools/indexer/example/src/configs.rs
Outdated
| @@ -1,5 +1,8 @@ | |||
| use near_indexer::near_primitives::types::Gas; | |||
|
|
|||
| /// Indexer uses the RPC configuration type. | |||
| const DOWNLOAD_CONFIG_TYPE: &str = "rpc"; | |||
There was a problem hiding this comment.
@khorolets please check here. simply I do not change --download-config flag, it is still boolean, but I map it to rpc config if it is specified.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
+ Coverage 71.43% 71.59% +0.15%
==========================================
Files 815 815
Lines 164218 164279 +61
Branches 164218 164279 +61
==========================================
+ Hits 117317 117609 +292
+ Misses 41772 41535 -237
- Partials 5129 5135 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marcelo-gonzalez
approved these changes
Sep 10, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the
--download-configparameter to take a string.neard init --download-config validatordownloads theconfig.jsonfile for validators (tracking single shard, loading memtries).neard init --download-config rpcdownloads theconfig.jsonfile for non-validator RPC nodes (tracking all shards, NOT loading memtries).neard init --download-config archivaldownloads theconfig.jsonfile for non-validator archival nodes (tracking all shards, NOT loading memtries, archive field set to true).neard init --download-config(with no value) defaults tovalidatorconfig (for backwards compatibility).We map the flag to a specific URL containing the config type.
The new config files per config type can be found at https://github.com/tayfunelmas/near-configs.
The new config files are already uploaded to AWS S3 with the new URLs.
NOTE: For indexer and chainsync-loadtest params, we use
rpcconfig type.Next: We will update the Near validator documentation to use the new flag value.
Tracking issue: #12070