Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(congestion_control) - set max_congestion_missed_chunks to 2 #11473

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Jun 4, 2024

Setting the max_congestion_missed_chunks to 2. This means that at most 2 (+/-1) chunks worth of outgoing receipts can accumulate before all shards will stop forwarding any receipts to the shard with missing chunks. This is a relatively conservative limit to minimize the impact of incoming receipts on source_receipt_proofs size in the state witness. I expect it to have minimal impact on the total throughput of the chain since it's quite rare to see more than one missed chunk in a row.

It's also worth noting that just having one missed chunk is a special case that will not increase the congestion level:

fn missed_chunks_congestion(&self) -> f64 {
if self.missed_chunks_count <= 1 {
return 0.0;
}

@wacban wacban requested a review from a team as a code owner June 4, 2024 16:20
@wacban wacban enabled auto-merge June 4, 2024 16:30
@wacban wacban added this pull request to the merge queue Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.36%. Comparing base (dd1e278) to head (61686b4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11473      +/-   ##
==========================================
- Coverage   71.37%   71.36%   -0.01%     
==========================================
  Files         787      787              
  Lines      159064   159099      +35     
  Branches   159064   159099      +35     
==========================================
+ Hits       113529   113539      +10     
- Misses      40623    40646      +23     
- Partials     4912     4914       +2     
Flag Coverage Δ
backward-compatibility 0.23% <0.00%> (-0.01%) ⬇️
db-migration 0.23% <0.00%> (-0.01%) ⬇️
genesis-check 1.37% <0.00%> (-0.01%) ⬇️
integration-tests 37.52% <18.18%> (+0.01%) ⬆️
linux 68.85% <18.18%> (-0.03%) ⬇️
linux-nightly 70.89% <100.00%> (+0.01%) ⬆️
macos 50.85% <0.00%> (-1.65%) ⬇️
pytests 1.58% <0.00%> (-0.01%) ⬇️
sanity-checks 1.38% <0.00%> (-0.01%) ⬇️
unittests 66.07% <81.81%> (-0.04%) ⬇️
upgradability 0.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into master with commit 3f684fd Jun 4, 2024
29 checks passed
@wacban wacban deleted the waclaw-ccc branch June 4, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants