feat(congestion_control) - Added more info to the InvalidCongestionInfo error #11461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakmeier
approved these changes
Jun 3, 2024
chain/chain/src/validate.rs
Outdated
Comment on lines
215
to
217
| (Some(_), None) => { | ||
| Err(Error::InvalidCongestionInfo("Congestion Information disappeared.".to_string())) | ||
| } |
There was a problem hiding this comment.
Would it make sense to include the extra congestion info in the string?
chain/chain/src/validate.rs
Outdated
Comment on lines
227
to
229
| Err(Error::InvalidCongestionInfo( | ||
| "Congestion Information invalid after protocol upgrade.".to_string(), | ||
| )) |
There was a problem hiding this comment.
Similarly, would it make sense to include the header congestion info in the string?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11461 +/- ##
==========================================
- Coverage 71.45% 71.44% -0.02%
==========================================
Files 785 785
Lines 158807 158817 +10
Branches 158807 158817 +10
==========================================
- Hits 113473 113461 -12
- Misses 40429 40455 +26
+ Partials 4905 4901 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.