Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yield_resume: stabilize #11277

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

nagisa
Copy link
Collaborator

@nagisa nagisa commented May 9, 2024

I believe I missed nothing, but let me know if I did.

cc @posvyatokum

@nagisa nagisa requested a review from saketh-are May 9, 2024 19:05
@nagisa nagisa requested a review from a team as a code owner May 9, 2024 19:05
@nagisa nagisa force-pushed the yield-resume-stabilization branch from b903a73 to 94b6b31 Compare May 9, 2024 19:17
Copy link
Collaborator

@saketh-are saketh-are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is one small thing here:

// TODO: we can remove this check once yield execution is stabilized.
// For now it prevents populating promise yield indices for the child shards with default
// values if the feature has not been enabled.
if insert_timeouts.is_empty() && delete_timeouts.is_empty() {
return Ok(());
}

I'd propose just deleting those 7 lines.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.97%. Comparing base (92ee5d2) to head (f6916c1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11277   +/-   ##
=======================================
  Coverage   70.96%   70.97%           
=======================================
  Files         781      781           
  Lines      155420   155417    -3     
  Branches   155420   155417    -3     
=======================================
+ Hits       110301   110305    +4     
- Misses      40349    40356    +7     
+ Partials     4770     4756   -14     
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (ø)
db-migration 0.24% <0.00%> (ø)
genesis-check 1.40% <0.00%> (+<0.01%) ⬆️
integration-tests 37.13% <100.00%> (-0.01%) ⬇️
linux 69.04% <100.00%> (+0.16%) ⬆️
linux-nightly 70.44% <100.00%> (+0.02%) ⬆️
macos 52.46% <100.00%> (-0.01%) ⬇️
pytests 1.63% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.42% <0.00%> (+<0.01%) ⬆️
unittests 65.41% <100.00%> (+<0.01%) ⬆️
upgradability 0.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagisa nagisa added this pull request to the merge queue May 9, 2024
Merged via the queue into near:master with commit 77d40ee May 9, 2024
29 checks passed
@nagisa nagisa deleted the yield-resume-stabilization branch May 9, 2024 21:10
posvyatokum pushed a commit that referenced this pull request May 15, 2024
I believe I missed nothing, but let me know if I did.

cc @posvyatokum
nagisa added a commit to nagisa/nearcore that referenced this pull request May 15, 2024
I believe I missed nothing, but let me know if I did.

cc @posvyatokum
posvyatokum added a commit that referenced this pull request May 15, 2024
posvyatokum pushed a commit that referenced this pull request May 15, 2024
I believe I missed nothing, but let me know if I did.

cc @posvyatokum
github-merge-queue bot pushed a commit that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants