-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yield_resume: stabilize #11277
yield_resume: stabilize #11277
Conversation
b903a73
to
94b6b31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There is one small thing here:
nearcore/core/store/src/trie/resharding.rs
Lines 343 to 349 in 92ee5d2
// TODO: we can remove this check once yield execution is stabilized. | |
// For now it prevents populating promise yield indices for the child shards with default | |
// values if the feature has not been enabled. | |
if insert_timeouts.is_empty() && delete_timeouts.is_empty() { | |
return Ok(()); | |
} | |
I'd propose just deleting those 7 lines.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11277 +/- ##
=======================================
Coverage 70.96% 70.97%
=======================================
Files 781 781
Lines 155420 155417 -3
Branches 155420 155417 -3
=======================================
+ Hits 110301 110305 +4
- Misses 40349 40356 +7
+ Partials 4770 4756 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I believe I missed nothing, but let me know if I did. cc @posvyatokum
I believe I missed nothing, but let me know if I did. cc @posvyatokum
This reverts commit 4e11f7a.
I believe I missed nothing, but let me know if I did. cc @posvyatokum
I believe I missed nothing, but let me know if I did.
cc @posvyatokum