support Included transaction status #10796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
approved these changes
Mar 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10796 +/- ##
==========================================
- Coverage 71.77% 71.76% -0.02%
==========================================
Files 758 758
Lines 152598 152613 +15
Branches 152598 152613 +15
==========================================
- Hits 109531 109516 -15
- Misses 38103 38130 +27
- Partials 4964 4967 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
posvyatokum
pushed a commit
that referenced
this pull request
Mar 14, 2024
Ideally, we need to rewrite `chain.get_final_transaction_result` method completely. But for now, let's start at least with supporting `TxExecutionStatus::Included` status.
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Mar 15, 2024
Ideally, we need to rewrite `chain.get_final_transaction_result` method completely. But for now, let's start at least with supporting `TxExecutionStatus::Included` status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, we need to rewrite
chain.get_final_transaction_resultmethod completely.But for now, let's start at least with supporting
TxExecutionStatus::Includedstatus.