Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix Linux StatelessNet Github CI #10731

Merged
merged 2 commits into from
Mar 8, 2024
Merged

[fix] Fix Linux StatelessNet Github CI #10731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eae5283
[fix] Fix statelessnet github CI
Mar 8, 2024
9ad3e6c
fix
Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/parameters/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,7 @@ nightly = [
nightly_protocol = [
"near-primitives-core/nightly_protocol",
]
statelessnet_protocol = [
"near-primitives-core/statelessnet_protocol",
]
calimero_zero_storage = []
4 changes: 2 additions & 2 deletions core/parameters/src/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,12 +611,12 @@ impl From<ExtCostsConfigView> for crate::ExtCostsConfig {
}

#[cfg(test)]
#[cfg(not(feature = "nightly"))]
#[cfg(not(feature = "statelessnet_protocol"))]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I still prefer ignore as it allows the test runner to see the total number of tests and indicate which ones have been ignored, but its not serious enough to block the PR over it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will keep in mind and change in some future random PR!

mod tests {
/// The JSON representation used in RPC responses must not remove or rename
/// fields, only adding fields is allowed or we risk breaking clients.
#[test]
#[cfg_attr(feature = "nightly", ignore)]
#[cfg_attr(feature = "statelessnet_protocol", ignore)]
fn test_runtime_config_view() {
use crate::view::RuntimeConfigView;
use crate::RuntimeConfig;
Expand Down
Loading