[resharding] Nightshade V3 shard layout for protocol version 65 #10725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyan-gupta
requested review from
gmilescu,
wacban,
posvyatokum and
marcelo-gonzalez
shreyan-gupta
commented
Mar 7, 2024
| @@ -184,6 +185,7 @@ impl ProtocolFeature { | |||
| ProtocolFeature::RestrictTla | |||
| | ProtocolFeature::TestnetFewerBlockProducers | |||
| | ProtocolFeature::SimpleNightshadeV2 => 64, | |||
| ProtocolFeature::SimpleNightshadeV3 => 65, | |||
There was a problem hiding this comment.
To be noted, STABLE_PROTOCOL_VERSION is already set as 65 on master. We may need to change this while cherry picking to 1.38.0
tayfunelmas
reviewed
Mar 7, 2024
added 2 commits
March 8, 2024 00:19
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10725 +/- ##
==========================================
+ Coverage 71.66% 71.70% +0.03%
==========================================
Files 756 756
Lines 152299 152362 +63
Branches 152299 152362 +63
==========================================
+ Hits 109150 109246 +96
+ Misses 38186 38139 -47
- Partials 4963 4977 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@pugachAG Are we going to need that cache/ prefetcher overrides as for shard 3? |
|
@wacban yes, you need to update should be pretty straightforward |
shreyan-gupta
commented
Mar 7, 2024
| @@ -235,10 +235,13 @@ impl Default for StoreConfig { | |||
| (ShardUId { version: 1, shard_id: 3 }, bytesize::ByteSize::gb(3)), | |||
| // In simple nightshade v2 the heavy contract "token.sweat" is in shard 4 | |||
| (ShardUId { version: 2, shard_id: 4 }, bytesize::ByteSize::gb(3)), | |||
| // In simple nightshade v3 the heavy contract "token.sweat" is in shard 5 | |||
| (ShardUId { version: 3, shard_id: 5 }, bytesize::ByteSize::gb(3)), | |||
There was a problem hiding this comment.
Confirming, shard_id gets pushed by one here
|
cc @posvyatokum and @marcelo-gonzalez I merged the new shard layout in preparation for 1.38 release. I will merge the integration tests for it next. |
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Mar 11, 2024
…#10725) This PR is to be cherry-picked into release 1.38.0 for splitting shard 2 into two parts. Hot and kai-ching both fall on shard 2 which has been causing a lot of congestion. Zulip thread: https://near.zulipchat.com/#narrow/stream/308695-nearone.2Fprivate/topic/constant.20congestion.20on.20shard.202/near/425367222 --------- Co-authored-by: wacban <wac.banasik@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
Please only refer to the last commit `7b289c9e763e96b6c863baeb7b80f9ec9c638620` or changes in file `integration-tests/src/tests/client/resharding.rs` I'm unable to create stacked PRs for my forked repo. To be merged only after #10725 --------- Co-authored-by: wacban <wac.banasik@gmail.com>
marcelo-gonzalez
pushed a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Mar 11, 2024
…#10725) This PR is to be cherry-picked into release 1.38.0 for splitting shard 2 into two parts. Hot and kai-ching both fall on shard 2 which has been causing a lot of congestion. Zulip thread: https://near.zulipchat.com/#narrow/stream/308695-nearone.2Fprivate/topic/constant.20congestion.20on.20shard.202/near/425367222 --------- Co-authored-by: wacban <wac.banasik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to be cherry-picked into release 1.38.0 for splitting shard 2 into two parts.
Hot and kai-ching both fall on shard 2 which has been causing a lot of congestion.
Zulip thread: https://near.zulipchat.com/#narrow/stream/308695-nearone.2Fprivate/topic/constant.20congestion.20on.20shard.202/near/425367222