Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some comments #10709

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix some comments #10709

merged 1 commit into from
Mar 6, 2024

Conversation

teslaedison
Copy link
Contributor

No description provided.

Signed-off-by: teslaedison <qingchengqiushuang@gmail.com>
@teslaedison teslaedison requested a review from a team as a code owner March 6, 2024 04:15
@akhi3030
Copy link
Collaborator

akhi3030 commented Mar 6, 2024

Thank you very much for your contribution. This looks ready to be merged I believe.

@akhi3030 akhi3030 enabled auto-merge March 6, 2024 08:36
@akhi3030 akhi3030 added this pull request to the merge queue Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.69%. Comparing base (ca97841) to head (609d0d7).
Report is 1 commits behind head on master.

Files Patch % Lines
chain/chunks/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10709      +/-   ##
==========================================
- Coverage   71.70%   71.69%   -0.01%     
==========================================
  Files         755      755              
  Lines      152172   152172              
  Branches   152172   152172              
==========================================
- Hits       109121   109107      -14     
- Misses      38081    38084       +3     
- Partials     4970     4981      +11     
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (ø)
db-migration 0.24% <0.00%> (ø)
genesis-check 1.42% <0.00%> (ø)
integration-tests 36.76% <33.33%> (+<0.01%) ⬆️
linux 70.52% <66.66%> (+<0.01%) ⬆️
linux-nightly 71.13% <66.66%> (-0.02%) ⬇️
macos 54.87% <50.00%> (+0.05%) ⬆️
pytests 1.65% <0.00%> (ø)
sanity-checks 1.43% <0.00%> (ø)
unittests 67.59% <50.00%> (-0.01%) ⬇️
upgradability 0.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit 8da50d7 Mar 6, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants