Fix: neard-release pipeline #10521
Merged
Fix: neard-release pipeline #10521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10521 +/- ##
==========================================
- Coverage 72.01% 71.99% -0.03%
==========================================
Files 720 720
Lines 146476 146476
Branches 146476 146476
==========================================
- Hits 105486 105456 -30
- Misses 36133 36158 +25
- Partials 4857 4862 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nagisa
approved these changes
Jan 29, 2024
| @@ -39,6 +39,8 @@ jobs: | |||
| - name: Checkout nearcore repository | |||
| if: ${{ github.event_name != 'workflow_dispatch'}} | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 | |||
posvyatokum
pushed a commit
that referenced
this pull request
Jan 30, 2024
#10495 was meant to fix the builds triggered by release events. With actions/checkout GHA action only a single commit is fetched by default and thus missing branch match. To fetch all history for all branches and tags, setting fetch-depth to 0 for both binary and docker image release jobs. This was [tested](https://github.com/near/andrei-playground/actions/runs/7696882172/job/20972653224) on a private repo. <img width="676" alt="Screenshot 2024-01-29 at 13 42 09" src="https://github.com/near/nearcore/assets/122784628/941c1cd8-285e-4853-a9e7-a6ea6885c838">
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2024
In #10521 I made checkout process to fetch all nearcore branches. This instead messed with master branch builds version because these are fetching latest annotated tag: ``` ➜ nearcore git:(master) git "describe" "--always" "--dirty=-modified" "--tags" "--match=[0-9]*" 1.36.1-653-g2b01868d4 ``` To avoid this, we will be fetching with depth 1(default fetch-depth) when workflow is triggered by master branch push events. ``` ➜ nearcore git:(master) git "describe" "--always" "--dirty=-modified" "--tags" "--match=[0-9]*" dfa392b ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10495 was meant to fix the builds triggered by release events.
With actions/checkout GHA action only a single commit is fetched by default and thus missing branch match.
To fetch all history for all branches and tags, setting fetch-depth to 0 for both binary and docker image release jobs.
This was tested on a private repo.
