Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract transaction_validity_check function #10519

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

pugachAG
Copy link
Contributor

Runtime prepare_transactions accepts chain_validate callback to perform additional transaction validation using data from chain. This PR extract common code into a separate function as part of Chain.

@pugachAG pugachAG added the C-housekeeping Category: Refactoring, cleanups, code quality label Jan 29, 2024
@pugachAG pugachAG requested a review from a team as a code owner January 29, 2024 12:29
@pugachAG pugachAG changed the title refactor: extract transaction_validity_check function refactor: extract transaction_validity_check function Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b3a16c6) 72.00% compared to head (900ca86) 72.01%.
Report is 2 commits behind head on master.

Files Patch % Lines
chain/client/src/client.rs 50.00% 0 Missing and 3 partials ⚠️
chain/client/src/chunk_validation.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10519      +/-   ##
==========================================
+ Coverage   72.00%   72.01%   +0.01%     
==========================================
  Files         720      720              
  Lines      146447   146476      +29     
  Branches   146447   146476      +29     
==========================================
+ Hits       105451   105491      +40     
+ Misses      36137    36135       -2     
+ Partials     4859     4850       -9     
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (-0.01%) ⬇️
db-migration 0.08% <0.00%> (-0.01%) ⬇️
genesis-check 1.25% <0.00%> (-0.01%) ⬇️
integration-tests 36.94% <82.60%> (+0.06%) ⬆️
linux 71.24% <73.91%> (+0.03%) ⬆️
linux-nightly 71.33% <82.60%> (-0.05%) ⬇️
macos 55.12% <73.91%> (+0.01%) ⬆️
pytests 1.47% <0.00%> (-0.01%) ⬇️
sanity-checks 1.27% <0.00%> (-0.01%) ⬇️
unittests 67.98% <73.91%> (-0.01%) ⬇️
upgradability 0.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pugachAG pugachAG added this pull request to the merge queue Jan 29, 2024
Merged via the queue into master with commit ad9721d Jan 29, 2024
26 checks passed
@pugachAG pugachAG deleted the trx-chain-validate-refactor branch January 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants