store: add methods to check for presence of a value without reading it out #10494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general looks reasonable to me. But maybe either @wacban or @shreyan-gupta can also validate. I'll give my approval. |
akhi3030
approved these changes
Jan 25, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10494 +/- ##
==========================================
+ Coverage 72.01% 72.02% +0.01%
==========================================
Files 720 720
Lines 146476 146558 +82
Branches 146476 146558 +82
==========================================
+ Hits 105486 105565 +79
+ Misses 36133 36130 -3
- Partials 4857 4863 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nagisa
force-pushed
the
nagisa/adds-has-received-data
branch
from
3b88260 to
93ae45f
Compare
nagisa
changed the base branch from
nagisa/improves-memstore-lookup-api
to
nagisa/adds-flat-lookup-api
nagisa
force-pushed
the
nagisa/adds-flat-lookup-api
branch
from
250b646 to
3642da6
Compare
Outstanding question: do we need or want to consult flat storage when checking for presence?
`get_received_data` has a property of returning the data read out from the storage which can result in the data being read out multiple times only for most of these reads to be immediately discarded. The newly added functions enable explicitly checking for presence of a key without reading out the corresponding value.
nagisa
force-pushed
the
nagisa/adds-has-received-data
branch
from
93ae45f to
fb68b79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed on a per-commit basis.
cc #10455