fix(metrics): fix false positives in the near_num_invalid_blocks metric #10468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
near#9316 extracted maybe_mark_block_invalid() as a helper function, but it changed the behavior so that near_num_invalid_blocks is incremented even if we're not marking a block as invalid. So fix it by just putting that metric increment inside the if block like it was before
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10468 +/- ##
==========================================
- Coverage 71.96% 71.96% -0.01%
==========================================
Files 719 719
Lines 145133 145133
Branches 145133 145133
==========================================
- Hits 104448 104446 -2
+ Misses 35885 35880 -5
- Partials 4800 4807 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Longarithm
approved these changes
Jan 20, 2024
marcelo-gonzalez
added a commit
to marcelo-gonzalez/nearcore
that referenced
this pull request
Jan 23, 2024
…ic (near#10468) near#9316 extracted maybe_mark_block_invalid() as a helper function, but it changed the behavior so that near_num_invalid_blocks is incremented even if we're not marking a block as invalid. So fix it by just putting that metric increment inside the if block like it was before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9316 extracted maybe_mark_block_invalid() as a helper function, but it changed the behavior so that near_num_invalid_blocks is incremented even if we're not marking a block as invalid. So fix it by just putting that metric increment inside the if block like it was before