feat(amend-genesis): allow setting the gas price #10389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After near/NEPs#92, the min gas price was set to 100M yoctoNEAR. But the genesis file we get from the state viewer dump-state command copies the 1B min gas price from the genesis file. This results in a network with 10x the gas fees as mainnet when we launch mocknet testing networks, and many transactions sent by the mirror run command fail with too little balance. So this PR allows setting the min/max gas prices in the mocknet genesis file so we can fix that. It might also be worth changing the behavior of `view-state dump-state` to set the min gas price, but this will work for now and lets us get the right gas price in all cases
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10389 +/- ##
==========================================
- Coverage 72.01% 72.00% -0.01%
==========================================
Files 718 718
Lines 144524 144532 +8
Branches 144524 144532 +8
==========================================
- Hits 104072 104066 -6
- Misses 35703 35711 +8
- Partials 4749 4755 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VanBarbascu
approved these changes
Jan 8, 2024
Really you can choose whatever you want to test with, but for these mocknet tests I'm going to set the value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After near/NEPs#92, the min gas price was set to 100M yoctoNEAR. But the genesis file we get from the state viewer dump-state command copies the 1B min gas price from the genesis file. This results in a network with 10x the gas fees as mainnet when we launch mocknet testing networks, and many transactions sent by the mirror run command fail with too little balance. So this PR allows setting the min/max gas prices in the mocknet genesis file so we can fix that. It might also be worth changing the behavior of
view-state dump-stateto set the min gas price, but this will work for now and lets us get the right gas price in all cases