Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resharding): fix dynamic config #10297

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Dec 5, 2023

Fixing the dynamic config since #10290 was accidentaly merged prematurely before it was fully tested and fixed.
Tested on localnet for now, will then test on mocknet and only then merge.

@wacban wacban requested a review from a team as a code owner December 5, 2023 09:59
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (71d0ea8) 71.81% compared to head (28fb536) 71.79%.
Report is 3 commits behind head on master.

Files Patch % Lines
chain/client/src/client.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10297      +/-   ##
==========================================
- Coverage   71.81%   71.79%   -0.02%     
==========================================
  Files         712      712              
  Lines      143052   143054       +2     
  Branches   143052   143054       +2     
==========================================
- Hits       102731   102708      -23     
- Misses      35607    35631      +24     
- Partials     4714     4715       +1     
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (ø)
db-migration 0.08% <0.00%> (ø)
genesis-check 1.25% <0.00%> (+<0.01%) ⬆️
integration-tests 36.11% <80.00%> (-0.11%) ⬇️
linux 71.67% <80.00%> (-0.02%) ⬇️
linux-nightly 71.38% <80.00%> (-0.01%) ⬇️
macos 53.88% <60.00%> (-0.01%) ⬇️
pytests 1.48% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.28% <0.00%> (+<0.01%) ⬆️
unittests 68.18% <60.00%> (-0.01%) ⬇️
upgradability 0.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wacban wacban changed the title fix(resharding): fix dynamic config update fix(resharding): fix dynamic config Dec 5, 2023
@wacban
Copy link
Contributor Author

wacban commented Dec 5, 2023

mocknet with updated config mid-fly

2023-12-05T13:55:47.792406Z  INFO config: Validating Config, extracted from config.json...
2023-12-05T13:55:47.792562Z  INFO near_o11y::reload: Updated the logging layer according to `log_config.json`
2023-12-05T13:55:47.847096Z  INFO check_triggers: config: Mutable config field 'expected_shutdown' remains the same: None
2023-12-05T13:55:47.847112Z  INFO check_triggers: config: Updated config field 'state_split_config' from StateSplitConfig { batch_size: 1000.0 KB, batch_delay: 1s, retry_delay: 50ms, initial_delay: 0ns, max_poll_time: 1800s } to StateSplitConfig { batch_size: 50.0 MB, batch_delay: 10ms, retry_delay: 50ms, initial_delay: 0ns, max_poll_time: 1800s }
2023-12-05T13:55:47.847940Z  INFO check_triggers: config: Updated ClientConfig
Screenshot 2023-12-05 at 13 58 44

@wacban wacban added this pull request to the merge queue Dec 5, 2023
Merged via the queue into master with commit a908de3 Dec 5, 2023
18 of 19 checks passed
@wacban wacban deleted the waclaw-resharding-dynamic-config branch December 5, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants