refactor: Rename BodySync to BlockSync for consistency #10293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10293 +/- ##
==========================================
- Coverage 71.82% 71.81% -0.02%
==========================================
Files 712 712
Lines 143055 143097 +42
Branches 143055 143097 +42
==========================================
+ Hits 102754 102763 +9
- Misses 35585 35630 +45
+ Partials 4716 4704 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I've turned off automatic merging altogether until I understand this problem. |
telezhnaya
reviewed
Dec 4, 2023
chain/client/src/sync/block.rs
Outdated
| fn get_last_processed_block( | ||
| &self, | ||
| chain: &Chain, | ||
| last_block_hash: &CryptoHash, |
There was a problem hiding this comment.
Why do I need to pass last_block_hash here? When I look at the signature, I don't expect to pass last_block_hash, I intend to receive it as the result
About implementation: why can't I just ask chain.store().get_latest_known?
There was a problem hiding this comment.
Added a TODO about get_latest_known().
shreyan-gupta
approved these changes
Dec 5, 2023
It solves the problem of nodes going into header sync or body sync for just a few seconds. It's not a problem for an rpc node, but for a validator that is enough to miss production of a chunk or a block. Short syncs are not shown in prometheus due to the large poll interval.
A refactoring of receiving blocks for StateSync. Logging is now more friendly to the traces format.
nikurt
force-pushed
the
nikurt-block-sync
branch
from
5228596
to
c4ef2d8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a bit of documentation for header sync.
And a bit of documentation of block sync.
And a bit of refactoring of block sync.
And a tiny refactoring related to state sync.
And a lot of TODOs.