bump wasmtime to 14.0.4 #10189
Merged
bump wasmtime to 14.0.4 #10189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekleog-NEAR
added
the
C-housekeeping
nagisa
reviewed
Nov 16, 2023
| @@ -161,9 +160,6 @@ skip = [ | |||
| # actix-http hasn't upgraded iminz_oxide/flate2 yet. | |||
| { name = "miniz_oxide", version = "=0.5.1" }, | |||
|
|
|||
| # webrtc-util depends on old version of nix depends on old version of memoffset | |||
There was a problem hiding this comment.
Admittedly if we’re not keen on maintaining these annotations/comments, then we’d be better off with none at all. It isn’t particularly hard to figure out where a dependency comes from later on with cargo tree or some other such tool.
There was a problem hiding this comment.
In particular now that memoffset has been moved to the block with "wasmer/wasmtime", the attribution isn’t exactly correct anymore.
There was a problem hiding this comment.
I totally agree, but didn’t really want to remove them all without discussion, so I only removed the ones I know we should be mostly responsible for :)
nagisa
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.