[fork-network] Optimize amend-access-keys using in-memory tries. #10176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikurt
approved these changes
Nov 15, 2023
core/store/src/config.rs
Outdated
| @@ -121,6 +121,8 @@ pub struct StoreConfig { | |||
|
|
|||
| // TODO (#9989): To be phased out in favor of state_snapshot_config | |||
| pub state_snapshot_compaction_enabled: bool, | |||
|
|
|||
| pub disable_rocksdb_compression: bool, | |||
There was a problem hiding this comment.
Removed the flag.
core/store/src/db/rocksdb.rs
Outdated
| @@ -528,7 +528,12 @@ fn rocksdb_column_options(col: DBCol, store_config: &StoreConfig, temp: Temperat | |||
| opts | |||
| } | |||
|
|
|||
| fn set_compression_options(opts: &mut Options) { | |||
| fn set_compression_options(opts: &mut Options, disable_compression: bool) { | |||
There was a problem hiding this comment.
(unrelated to this line)
Please mention somewhere in fork-network comments, that you recommend disabling rocksdb compression and what kind of speed up can be expected.
There was a problem hiding this comment.
Actually, I tried without it and there's no real difference (~70min vs ~80min). Compression spins up more threads to do compression, using up more CPU, but there's enough CPU with 8 cores anyway.
robin-near
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://near.zulipchat.com/#narrow/stream/297873-pagoda.2Fnode/topic/New.20betanet.20infra